FIX: couple issues on Staking Page #1943
Merged
+28
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NeoPlays
commented
Jul 16, 2024
•
NeoPlays
commented
- fixes some smaller stuff on Staking page (still not perfect)
- removed loading when entering Control / Node Page
- fixed small bug on edit page
MaxTheGeeek
reviewed
Jul 16, 2024
| @@ -165,7 +165,7 @@ export default { | |||
| let test = []; | |||
| const selectedSetup = this.selectedSetup; | |||
| if (selectedSetup && selectedSetup.services) { | |||
| const selectedServiceIds = selectedSetup.services.map((service) => service.id); | |||
| const selectedServiceIds = selectedSetup.services.map((service) => service.config.serviceID); | |||
There was a problem hiding this comment.
is it correct? we do NOT have service.config.serviceID in the selectedSetup.
There was a problem hiding this comment.
yes we do, because i changed it. the services in selectedSetup is now the same data as in InstalledServices.
before we had to manage 2 different service states which not only broke stuff, but also made everything very hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.